-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support server side rendering #147
base: master
Are you sure you want to change the base?
Conversation
What's the purpose of this? Why would you want to use a library for keyboard shortcuts on the server? |
Not meant to use on the server, but if included on the server it shouldn't throw an error. When working with techs like react where your components also usually need to be rendered on the server side including keymaster dependency shouldn't throw an error. (of course I don't call it unless it's on the client side) at least this is my use case |
Please merge this. |
Would really really love to see this merged! |
is there a chance that this PR will be merged? |
Same needing here – using with next.js. |
Alternative library on modern js supports SSR https://github.com/elv1n/keybuddy |
I've merged this here |
Prevents use of window when it is not defined to allow server side rendering